[webkit-reviews] review denied: [Bug 136855] [Curl] Sometimes incomplete or empty content can be loaded from cache. : [Attachment 238184] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <alex.christensen at flexsim.com> has denied peavo at outlook.com's
request for review:
Bug 136855: [Curl] Sometimes incomplete or empty content can be loaded from
cache.
https://bugs.webkit.org/show_bug.cgi?id=136855

Attachment 238184: Patch
https://bugs.webkit.org/attachment.cgi?id=238184&action=review

------- Additional Comments from Alex Christensen
<alex.christensen at flexsim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238184&action=review


This looks mostly good.  r- only because it needs another patch and I have a
question.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:119
> +    if (buffer.size() > 0)

is buffer.size() signed?  I think this should just be if (buffer.size()).

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:221
> +	       cacheEntry->setIsLoading(true);

This not only sets the loading flag, but it calls openContentFile.  Is this
intentional?