[webkit-reviews] review granted: [Bug 136487] [iOS] Make WebCore build with public iOS SDK : [Attachment 238134] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 136487: [iOS] Make WebCore build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=136487

Attachment 238134: Patch
https://bugs.webkit.org/attachment.cgi?id=238134&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238134&action=review


r=me with a couple comments

> Source/WebCore/platform/spi/ios/CUICatalogSPI.h:37
> + at interface CUICatalog : NSObject
> +
> + at end

NIt: Any reason to leave a blank line here?  Could be removed in other files as
well.  Not necessary to fix to land the patch, though.

> Source/WebKit/mac/MigrateHeaders.make:245
> -WEBCORE_HEADER_REPLACE_RULES = -e s/\<WebCore/\<WebKitLegacy/ -e
s/DOMDOMImplementation/DOMImplementation/ -e "s/(^ *)WEBCORE_EXPORT /\1/"
> -WEBCORE_HEADER_MIGRATE_CMD = sed -E $(WEBCORE_HEADER_REPLACE_RULES) $< > $@
> +WEBCORE_HEADER_REPLACE_RULES = 's/<WebCore/<WebKitLegacy/ if
m|<WebCore/([^>]+)>| && $$1 !~ /SPI.h$$/;
s/DOMDOMImplementation/DOMImplementation/; s/^(\s*)WEBCORE_EXPORT /$$1/;'
> +WEBCORE_HEADER_MIGRATE_CMD = perl -p -e $(WEBCORE_HEADER_REPLACE_RULES) $< >
$@

Do you have to double-up the backslash in "(\s*)" to "(\\s*)"?

Did you do a recursive diff (diff -urN) between a DerivedSources directory with
clean builds including this change and a clean build without this change to
make sure there were no unexpected differences?  (Or something similar.)