[webkit-reviews] review granted: [Bug 136853] [EFL][GTK] Remove WebKit1 related codes : [Attachment 238174] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 16 06:58:51 PDT 2014
Csaba Osztrogonác <ossy at webkit.org> has granted Nagy Renátó
<rnagy at inf.u-szeged.hu>'s request for review:
Bug 136853: [EFL][GTK] Remove WebKit1 related codes
https://bugs.webkit.org/show_bug.cgi?id=136853
Attachment 238174: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=238174&action=review
------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238174&action=review
LGTM, with a little nit.
> Tools/Scripts/webkitpy/port/gtk.py:213
> + def test_expectations_file_position(self):
> + return 2
It would be great to have a similar comment to efl.py here.
More information about the webkit-reviews
mailing list