[webkit-reviews] review granted: [Bug 136821] Remove ORWT related crufts from webkitdirs.pm : [Attachment 238122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 20:13:10 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has granted Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>'s request for review:
Bug 136821: Remove ORWT related crufts from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=136821

Attachment 238122: Patch
https://bugs.webkit.org/attachment.cgi?id=238122&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238122&action=review


r=me assuming that webkitperl tests passed (test-webkitperl). EWS doesn't run
these.

> Tools/Scripts/webkitdirs.pm:-1184
> -sub isPerianInstalled()

Interesting - there was recently a conjecture that tests fail on some machines
because of Perian. Perhaps we should start checking for it in nrwt.


More information about the webkit-reviews mailing list