[webkit-reviews] review granted: [Bug 22263] Web Inspector: mouse drifts away from resizer when resizing docked inspector : [Attachment 238135] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 15 13:43:25 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 22263: Web Inspector: mouse drifts away from resizer when resizing docked
inspector
https://bugs.webkit.org/show_bug.cgi?id=22263

Attachment 238135: Patch
https://bugs.webkit.org/attachment.cgi?id=238135&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238135&action=review


r=me!

> Source/WebInspectorUI/UserInterface/Base/Main.js:1302
> +	   // Cursor position cannot be less than initial mouse down position
when resizing docked Inspector smaller.

Maybe we should clarify these comments. "initial mouse down position" =>
"initial mouse down position within the window". Since that is what clientX/Y
are giving us.


More information about the webkit-reviews mailing list