[webkit-reviews] review granted: [Bug 136766] Introduce FONT_DATA_TYPE_CASTS, and use it : [Attachment 238004] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at webkit.org>'s request for review:
Bug 136766: Introduce FONT_DATA_TYPE_CASTS, and use it
https://bugs.webkit.org/show_bug.cgi?id=136766

Attachment 238004: Patch
https://bugs.webkit.org/attachment.cgi?id=238004&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238004&action=review


> Source/WebCore/platform/graphics/FontGlyphs.cpp:74
> +	  
fontCache().releaseFontData(toSimpleFontData(m_realizedFontData[i]));

I don’t understand why the .get() isn’t needed any more.

> Source/WebCore/platform/graphics/FontGlyphs.cpp:82
> -	   m_pitch = static_cast<const SimpleFontData*>(fontData)->pitch();
> +	   m_pitch = toSimpleFontData(fontData)->pitch();

Should be toSimpleFontData(*fontData).pitch()

> Source/WebCore/platform/graphics/FontGlyphs.cpp:84
> -	   const SegmentedFontData* segmentedFontData = static_cast<const
SegmentedFontData*>(fontData);
> +	   const SegmentedFontData* segmentedFontData =
toSegmentedFontData(fontData);

Should be a reference, not a pointer, since it can’t be null.