[webkit-reviews] review granted: [Bug 136775] Generate toFooElementData() using ELEMENT_DATA_TYPE_CASTS : [Attachment 238019] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at webkit.org>'s request for review:
Bug 136775: Generate toFooElementData() using ELEMENT_DATA_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=136775

Attachment 238019: Patch
https://bugs.webkit.org/attachment.cgi?id=238019&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238019&action=review


> Source/WebCore/dom/ElementData.h:186
> +    TYPE_CASTS_BASE(ToValueTypeName, ElementData, elementData,
pointerPredicate, referencePredicate)

We need to fix TYPE_CASTS_BASE. It’s kind of dumb that we need one expression
for -> and one for . in every single invocation. We can use *(x) in the macro
to dereference the pointer instead. We should go make that change globally to
make every single use of the macro simpler.