[webkit-reviews] review granted: [Bug 135701] [CSS Grid Layout] Sort items by span when resolving content-based track sizing functions : [Attachment 238028] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 135701: [CSS Grid Layout] Sort items by span when resolving content-based
track sizing functions
https://bugs.webkit.org/show_bug.cgi?id=135701

Attachment 238028: Patch
https://bugs.webkit.org/attachment.cgi?id=238028&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238028&action=review


> Source/WebCore/rendering/RenderGrid.cpp:544
> +    RenderBox* gridItem() const { return m_gridItem; }

This should return RenderBox&.

> Source/WebCore/rendering/RenderGrid.cpp:553
> +    RenderBox* m_gridItem;

This could also be std::reference_wrapper<RenderBox>.

> Source/WebCore/rendering/RenderGrid.cpp:563
>      for (size_t i = 0; i < sizingData.contentSizedTracksIndex.size(); ++i) {

>	   GridIterator iterator(m_grid, direction,
sizingData.contentSizedTracksIndex[i]);

This loop should be a modern for loop.