[webkit-reviews] review granted: [Bug 136759] Web Inspector: remind about rebaselining generator test results : [Attachment 238058] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136759: Web Inspector: remind about rebaselining generator test results
https://bugs.webkit.org/show_bug.cgi?id=136759

Attachment 238058: Patch
https://bugs.webkit.org/attachment.cgi?id=238058&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review


> Tools/Scripts/webkitpy/common/config/watchlist:203
> +	       "filename": r"Source/JavaScriptCore/inspector/scripts/codegen",

We may also want the generator script itself:

   
Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py


> Tools/Scripts/webkitpy/common/config/watchlist:394
> +	   "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs
generator. Please ensure that you have rebaselined any generator test results
(i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ]


Throw a trailing comma! The others have it, and it makes future diffs much
nicer =)