[webkit-reviews] review granted: [Bug 136786] Un-inline Element constructor : [Attachment 238038] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 12 11:28:13 PDT 2014
Benjamin Poulain <benjamin at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 136786: Un-inline Element constructor
https://bugs.webkit.org/show_bug.cgi?id=136786
Attachment 238038: Patch
https://bugs.webkit.org/attachment.cgi?id=238038&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
My rule of thumb is to put the create() function out of line, and the
constructor inline.
Before landing, you should check if the 8k of binary size are not caused by a
subclass that use an inline create().
More information about the webkit-reviews
mailing list