[webkit-reviews] review denied: [Bug 136779] Remove shouldAbortEarly cruft from master.cfg : [Attachment 238022] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 12 09:05:12 PDT 2014
Csaba Osztrogonác <ossy at webkit.org> has denied Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 136779: Remove shouldAbortEarly cruft from master.cfg
https://bugs.webkit.org/show_bug.cgi?id=136779
Attachment 238022: Patch
https://bugs.webkit.org/attachment.cgi?id=238022&action=review
------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238022&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-381
> - self.setCommand(self.command +
["--exit-after-n-crashes-or-timeouts", "50", "--exit-after-n-failures", "500"])
This line shouldn't be removed, we need --exit-after-* unconditionally.
(shouldAbortEarly is always True)
More information about the webkit-reviews
mailing list