[webkit-reviews] review granted: [Bug 136575] [CSS Grid Layout] Do not grow tracks when the growth factor is 0 : [Attachment 237690] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 12 07:24:07 PDT 2014


Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 136575: [CSS Grid Layout] Do not grow tracks when the growth factor is 0
https://bugs.webkit.org/show_bug.cgi?id=136575

Attachment 237690: Patch
https://bugs.webkit.org/attachment.cgi?id=237690&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If this really makes such a significant difference, there are a lot of other
things you should consider to make this code faster. The most obvious one would
be to consider if "track.m_maxBreadth - trackBreadth" is usually 0 and if so,
skip the availableLogicalSpaceShare computation entirely.

It seems bizarre that this would be so hot that adding the branch just to avoid
some addition and subtraction operations would make a measurable difference.


More information about the webkit-reviews mailing list