[webkit-reviews] review granted: [Bug 136669] REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model : [Attachment 238024] Rebased to apply on current git master

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136669: REGRESSION(r173423): CertificateInfo is never sent to the UI
process when using shared secondary process model
https://bugs.webkit.org/show_bug.cgi?id=136669

Attachment 238024: Rebased to apply on current git master
https://bugs.webkit.org/attachment.cgi?id=238024&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=238024&action=review


> Source/WebCore/loader/DocumentLoader.cpp:1435
> +    static NeverDestroyed<ResourceLoaderOptions>
mainResourceLoadOptions(SendCallbacks, SniffContent, BufferData,
AllowStoredCredentials, AskClientForAllCredentials, SkipSecurityCheck,
UseDefaultOriginRestrictionsForType, IncludeCertificateInfo);

It would be nice to refactor ResourceLoaderOptions to be in the style of
ViewState::Flags and LayerFlushThrottleState::Flags. The current struct is very
expansion unfriendly.