[webkit-reviews] review granted: [Bug 136615] [GTK] Use a nicer HTTP authentication dialog : [Attachment 237966] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 136615: [GTK] Use a nicer HTTP authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=136615

Attachment 237966: Patch
https://bugs.webkit.org/attachment.cgi?id=237966&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237966&action=review


Thanks, I would only change a couple of things before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
> +	   label = gtk_label_new(message.get());
> +	   gtk_misc_set_alignment(GTK_MISC(label), 0, 0.5);
> +	   gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
> +	   gtk_label_set_max_width_chars(GTK_LABEL(label), 40);
> +	   gtk_widget_show(label);
> +	   gtk_box_pack_start(GTK_BOX(authBox), label, FALSE, FALSE, 0);

This is pretty much the same block than the previous one. We could move it to a
helper function. Something like the createLabel you are removing, but without
the padding parameter.

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:132
> +    gtk_style_context_add_class(gtk_widget_get_style_context(loginLabel),
"dim-label");

Use GTK_STYLE_CLASS_DIM_LABEL instead of "dim-label"

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:143
> +    gtk_style_context_add_class(gtk_widget_get_style_context(passwordLabel),
"dim-label");

Ditto.