[webkit-reviews] review granted: [Bug 136763] Simplify DOM tree traversal in FrameSelection::setSelectionFromNone() : [Attachment 237992] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 136763: Simplify DOM tree traversal in
FrameSelection::setSelectionFromNone()
https://bugs.webkit.org/show_bug.cgi?id=136763

Attachment 237992: Patch
https://bugs.webkit.org/attachment.cgi?id=237992&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237992&action=review


> Source/WebCore/editing/FrameSelection.cpp:2117
> +    Element* documentElement = document->documentElement();
> +    if (!documentElement)
> +	   return;

If I were you, I'd declare documentElement inside the if condition and nest the
if's.