[webkit-reviews] review granted: [Bug 136760] lldb_webkit.py:btjs doesn't work with release builds : [Attachment 237989] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 136760: lldb_webkit.py:btjs doesn't work with release builds
https://bugs.webkit.org/show_bug.cgi?id=136760

Attachment 237989: Patch
https://bugs.webkit.org/attachment.cgi?id=237989&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237989&action=review


r=me, with nit:

> Tools/lldb/lldb_webkit.py:135
> +		   JSFrameDescription =
frame.EvaluateExpression("(char*)_ZN3JSC9ExecState13describeFrameEv(0x%x)" %
frame.GetFP()).GetSummary()

It may make sense to add an "assert" which looks up that symbol and prints a
sensible error message if it can't be found.