[webkit-reviews] review granted: [Bug 136734] Check for varying packing restrictions per program instead of per shader : [Attachment 237961] patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 136734: Check for varying packing restrictions per program instead of per
shader
https://bugs.webkit.org/show_bug.cgi?id=136734

Attachment 237961: patch
https://bugs.webkit.org/attachment.cgi?id=237961&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237961&action=review


> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:368

> +	   const char* builtIns[] = {
> +	       "gl_FragCoord",
> +	       "gl_FrontFacing",
> +	       "gl_PointCoord"
> +	   };
> +
> +	   bool isBuiltIn = false;
> +	   for (int i = 0; i < 3; ++i) {
> +	       if (symbolName == builtIns[i]) {
> +		   isBuiltIn = true;
> +		   break;
> +	       }
> +	   }
> +
> +	   if (isBuiltIn)
> +	       continue;

I don't really have a preference here, but maybe it might be simpler to do if
(symbolName == "gl_FragCoord" || symbolName ==...) continue;