[webkit-reviews] review granted: [Bug 136721] Rename activation to be more in line with spec language : [Attachment 237960] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 136721: Rename activation to be more in line with spec language
https://bugs.webkit.org/show_bug.cgi?id=136721

Attachment 237960: Patch
https://bugs.webkit.org/attachment.cgi?id=237960&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237960&action=review


r=me

> Source/JavaScriptCore/bytecode/CallVariant.h:41
> +//	  instance, that is associated with a particular lexical environment.
This pinpoints not just the code

Reflow the comment so that all lines break about the same length.

> Source/JavaScriptCore/debugger/DebuggerScope.cpp:168
> +    // lexical environment object. Hence, a lexical environment object
implies a function or eval scope.

Reflow the comment line breaks.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:473
> +    // a lexical environment object, the lexical environment object will
only be set up after

Reflow the comment line breaks.

> Source/JavaScriptCore/runtime/Arguments.cpp:388
> +    // If we have a captured argument that logically aliases lexical
environment storage,
> +    // but we optimize away the lexicalEnvironment, the argument needs to
tear off into

Reflow the comment line breaks.

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:2
> + * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.

Add 2014

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:2
> + * Copyright (C) 2008, 2009, 2013 Apple Inc. All rights reserved.

Add 2014