[webkit-reviews] review denied: [Bug 136711] Merge some Blink webkitpy Changes : [Attachment 237907] Correct merge error.

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 136711: Merge some Blink webkitpy Changes
https://bugs.webkit.org/show_bug.cgi?id=136711

Attachment 237907: Correct merge error.
https://bugs.webkit.org/attachment.cgi?id=237907&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237907&action=review


Merging many different fixes in one huge patch isn't a good idea.
Additionally we should add references to the original changes
and describe the reason why we need a fix to be merged.

> Tools/Scripts/webkitpy/tool/grammar.py:41
> -def pluralize(count, noun, showCount=True):
> +def pluralize(noun, count, showCount=True):

I don't agree with this change. It was modified intentionally 
to be be more understandable, please don't change it back.

To get "2 patches" now, you can simple do it with pluralize(2, "patch").
Why do you think if pluralize("patch", 2) would be better< To be closer to
Blink's webkitpy isn't a good reason.