[webkit-reviews] review granted: [Bug 136662] Web Inspector: DOM Tree search highlights are not appearing : [Attachment 237932] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 11 00:07:04 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136662: Web Inspector: DOM Tree search highlights are not appearing
https://bugs.webkit.org/show_bug.cgi?id=136662

Attachment 237932: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=237932&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237932&action=review


> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:506
> +	   this._searchResultNodes.forEach(function(domNode) {
> +	       var treeElement = this._domTreeOutline.findTreeElement(domNode);

> +	       if (treeElement)
> +		   treeElement.hideSearchHighlights();
> +	   }, this);

for(..of..)?


More information about the webkit-reviews mailing list