[webkit-reviews] review granted: [Bug 136500] Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector : [Attachment 237922] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Saam Barati
<saambarati1 at gmail.com>'s request for review:
Bug 136500: Web Inspector: Modify the type profiler runtime protocol to
transfer some computation into the WebInspector
https://bugs.webkit.org/show_bug.cgi?id=136500

Attachment 237922: patch
https://bugs.webkit.org/attachment.cgi?id=237922&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237922&action=review


r=me!

> Source/JavaScriptCore/inspector/protocol/Runtime.json:148
> +		   { "name": "primitiveTypeNames", "type": "array", "items": {
"type": "string" }, "optional": true, "description": "Array of type names for
primtive types (int, string, etc) seen at an instruction" },

Typo: "primtive" => "primitive"
Nit: Comment should end in a period.