[webkit-reviews] review granted: [Bug 136569] offlineasm generates suboptimal code for load/store on ARM64 : [Attachment 237682] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 10 14:06:10 PDT 2014


Michael Saboff <msaboff at apple.com> has granted Akos Kiss
<akiss at inf.u-szeged.hu>'s request for review:
Bug 136569: offlineasm generates suboptimal code for load/store on ARM64
https://bugs.webkit.org/show_bug.cgi?id=136569

Attachment 237682: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=237682&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237682&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   base to the temporary, and the change the load/store to use the

"the change" -> "then change"

> Source/JavaScriptCore/ChangeLog:13
> +	   perform explicit register additons but it is enough to change
load/store

Typo: "additions"


More information about the webkit-reviews mailing list