[webkit-reviews] review granted: [Bug 136701] NetworkResourceLoader cleanups : [Attachment 237890] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 136701: NetworkResourceLoader cleanups
https://bugs.webkit.org/show_bug.cgi?id=136701

Attachment 237890: patch
https://bugs.webkit.org/attachment.cgi?id=237890&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237890&action=review


> Source/WebKit2/NetworkProcess/NetworkResourceLoader.h:78
> +    const WebCore::ResourceRequest& originalRequest() const { return
m_parameters.request; }
> +    // Changes with redirects.
> +    WebCore::ResourceRequest& currentRequest() { return m_currentRequest; }

The paragraphing here made it hard for me to understand the comment. I would
put a blank line before the comment.

> Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp:133
> +	   for (size_t i = 0, count =
requestBodySandboxExtensionHandles.size(); i < count; ++i) {

Modern for loop would be better.

> Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp:135
> +		   result.requestBodySandboxExtensions.append(extension);

extension.release()