[webkit-reviews] review granted: [Bug 136498] Delete class SavedDrawingStateForMask : [Attachment 237868] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 10 08:34:49 PDT 2014


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 136498: Delete class SavedDrawingStateForMask
https://bugs.webkit.org/show_bug.cgi?id=136498

Attachment 237868: Patch
https://bugs.webkit.org/attachment.cgi?id=237868&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review


> Source/WebCore/rendering/TextPainter.cpp:139
> +	       TextRun& emphasisMarkTextRun = m_combinedText ?
static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun;

Instead of:

    static_cast<TextRun&>(objectReplacementCharacterTextRun)

Should use:

    objectReplacementCharacterTextRun.get()


More information about the webkit-reviews mailing list