[webkit-reviews] review granted: [Bug 136654] Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function signatures inside #ifdefs : [Attachment 237862] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136654: Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function
signatures inside #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136654

Attachment 237862: Patch
https://bugs.webkit.org/attachment.cgi?id=237862&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237862&action=review


> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:102
>	   for (HTMLToken::AttributeList::const_iterator iter =
attributes.begin(); iter != attributes.end(); ++iter) {

Opportunity for new-style for loop.

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:112
> +	       sourceSize =
SourceSizeList::parseSizesAttribute(m_sizesAttribute, document.renderView(),
document.frame());

I suggest pushing down Document& even further, and changing the interface to
SourceSizeList to take Document&.

> Source/WebCore/html/parser/HTMLPreloadScanner.h:50
> +    void scan(const HTMLToken&, PreloadRequestStream& requests, Document&);

I don’t think the argument name “requests” adds anything here.

> Source/WebCore/html/parser/HTMLPreloadScanner.h:130
> +    void scan(HTMLResourcePreloader*, Document&);

Should be HTMLResourcePreloader&.