[webkit-reviews] review granted: [Bug 135255] Merge CheckingContexts from SelectorCompiler and SelectorChecker : [Attachment 237852] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 17:56:07 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 135255: Merge CheckingContexts from SelectorCompiler and SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=135255

Attachment 237852: Patch
https://bugs.webkit.org/attachment.cgi?id=237852&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237852&action=review


> Source/WebCore/ChangeLog:17
> +	   always VisitedMatchDisabled. In this patch, we rename
SelectorCheckerFastPath to SelectorQueryFastPath, and
> +	   drop VisitedMatchType parameter.

The part regarding SelectorCheckerFastPath needs to be updated.

> Source/WebCore/css/SelectorChecker.cpp:66
> +    // Initial selector constructor

No need for the comment.


More information about the webkit-reviews mailing list