[webkit-reviews] review granted: [Bug 136668] Add support for :read-write/:read-only matching editable content : [Attachment 237843] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 13:00:00 PDT 2014


Antti Koivisto <koivisto at iki.fi> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 136668: Add support for :read-write/:read-only matching editable content
https://bugs.webkit.org/show_bug.cgi?id=136668

Attachment 237843: Patch
https://bugs.webkit.org/attachment.cgi?id=237843&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=237843&action=review


r=me

> Source/WebCore/rendering/RenderTheme.cpp:843
>  bool RenderTheme::isReadOnlyControl(const RenderObject& o) const

With some more refactoring this could surely be turned into RenderElement& or
something mores specific and the type check below eliminated...


More information about the webkit-reviews mailing list