[webkit-reviews] review granted: [Bug 136650] Rubber-banding in the DOM view of the WebInspector is really jumpy : [Attachment 237822] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 136650: Rubber-banding in the DOM view of the WebInspector is really jumpy
https://bugs.webkit.org/show_bug.cgi?id=136650

Attachment 237822: Patch
https://bugs.webkit.org/attachment.cgi?id=237822&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237822&action=review


> Source/WebCore/rendering/RenderLayer.cpp:1390
> +    if
(!renderer().frame().settings().rubberBandingForOverflowScrollEnabled())
> +	   return false;

Do you need to check the setting here, since presumably overhangAmount() will
just return 0,0 otherwise?