[webkit-reviews] review granted: [Bug 136613] Make OSObjectPtr a bit more like RefPtr : [Attachment 237757] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 7 18:03:03 PDT 2014


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 136613: Make OSObjectPtr a bit more like RefPtr
https://bugs.webkit.org/show_bug.cgi?id=136613

Attachment 237757: Patch
https://bugs.webkit.org/attachment.cgi?id=237757&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237757&action=review


> Source/WTF/wtf/OSObjectPtr.h:52
>  struct AdoptOSObject { };

Now that this is not part of the public API of OSObjectPtr, could make this
struct a private member of the OSObjectPtr class. Would be tidier.

> Source/WTF/wtf/OSObjectPtr.h:122
> +    OSObjectPtr& operator=(const OSObjectPtr&& other)

Unwanted const here prevents the patch from compiling.


More information about the webkit-reviews mailing list