[webkit-reviews] review granted: [Bug 136584] Laying out a TextRun using an SVG font is O(n^2) : [Attachment 237728] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 136584: Laying out a TextRun using an SVG font is O(n^2)
https://bugs.webkit.org/show_bug.cgi?id=136584

Attachment 237728: Patch
https://bugs.webkit.org/attachment.cgi?id=237728&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237728&action=review


r=me

> Source/WebCore/platform/graphics/TextRun.cpp:61
> +    if (m_normalizedSpaces.length() !=
static_cast<unsigned>(charactersLength())) {

Could do early return here.

>> Source/WebCore/platform/graphics/TextRun.h:239
>> +	mutable String m_normalizedSpaces;
> 
> We may want this cached value to live in WidthIterator::advanceInternal()
instead of in TextRun.

I agree.