[webkit-reviews] review granted: [Bug 136590] Doing a navigation on a non-opaque WKWebView can result in an empty layer tree : [Attachment 237719] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 5 16:42:17 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 136590: Doing a navigation on a non-opaque WKWebView can result in an empty
layer tree
https://bugs.webkit.org/show_bug.cgi?id=136590

Attachment 237719: patch
https://bugs.webkit.org/attachment.cgi?id=237719&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237719&action=review


> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * page/FrameView.cpp:

You fail to explain the "can result in an empty layer tree" part here.

> Source/WebCore/page/FrameView.cpp:2586
> +    if (&renderView->frameView() != this)
> +	   return;

This deserves a comment.


More information about the webkit-reviews mailing list