[webkit-reviews] review granted: [Bug 136474] Remove PLATFORM(IOS) from WebCore/editing : [Attachment 237715] Patch3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 5 16:00:40 PDT 2014
Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 136474: Remove PLATFORM(IOS) from WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=136474
Attachment 237715: Patch3
https://bugs.webkit.org/attachment.cgi?id=237715&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237715&action=review
> Source/WebCore/page/mac/WebCoreFrameView.h:32
> class Frame;
> + class IntPoint;
Wrong indent here.
> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:300
> + toDOMRange:kit(toRange)
affinity:(selectionAffinity == UPSTREAM) ? NSSelectionAffinityUpstream :
NSSelectionAffinityDownstream
I am not a fan of the 3 copies of "(selectionAffinity == UPSTREAM) ?
NSSelectionAffinityUpstream : NSSelectionAffinityDownstream".
I would have static inline for that.
More information about the webkit-reviews
mailing list