[webkit-reviews] review granted: [Bug 136545] Serialize ResourceResponses using WebKit types : [Attachment 237693] patch 2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 136545: Serialize ResourceResponses using WebKit types
https://bugs.webkit.org/show_bug.cgi?id=136545

Attachment 237693: patch 2
https://bugs.webkit.org/attachment.cgi?id=237693&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237693&action=review


Antti checked what CFNetwork serialization code does, and it seems like we
don't lose much.

r=me with the comments addressed, and Gtk build fixed.

> Source/WebCore/platform/network/ResourceResponseBase.h:232
> +    if (!decoder.decode(response.m_httpStatusText))
> +	   return false;

We need a Radar and a FIXME somewhere (not here) about how we fail to add
m_httpStatusText to NSURLResponse when re-creating it.

This patch fixes status text for XHR, but breaks it for API clients.

The XHR issue this fixes is rdar://problem/13751647, please unskip the tests.