[webkit-reviews] review granted: [Bug 136561] Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots : [Attachment 237663] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136561: Add some logging to help diagnose assertions in
dumpWebViewAsPixelsAndCompareWithExpected() on bots
https://bugs.webkit.org/show_bug.cgi?id=136561

Attachment 237663: Patch
https://bugs.webkit.org/attachment.cgi?id=237663&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237663&action=review


> Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:58
> +	   WTFLogAlways("calloc(%llu, %llu) failed\n", pixelsHigh, rowBytes);

Can we throw a note in here about where these are coming from?
("DumpRenderTree: calloc...").