[webkit-reviews] review granted: [Bug 136546] [Win] webkitpy test suite frequently fails to complete : [Attachment 237658] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 4 16:43:30 PDT 2014


Daniel Bates <dbates at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 136546: [Win] webkitpy test suite frequently fails to complete
https://bugs.webkit.org/show_bug.cgi?id=136546

Attachment 237658: Patch
https://bugs.webkit.org/attachment.cgi?id=237658&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237658&action=review


> Tools/ChangeLog:12
> +	   We were mixing ascii/unicode strings under Windows, which was

Nit: ascii => ASCII
unicode => Unicode

> Tools/Scripts/webkitpy/common/system/crashlogs.py:92
> +		       log_file =
self._host.filesystem.read_binary_file(path).decode('ascii', 'ignore')

I assume it's always acceptable to decode the file as ASCII regardless of the
platform.


More information about the webkit-reviews mailing list