[webkit-reviews] review denied: [Bug 136526] Committed URL is not reset when a new load starts : [Attachment 237616] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136526: Committed URL is not reset when a new load starts
https://bugs.webkit.org/show_bug.cgi?id=136526

Attachment 237616: Patch
https://bugs.webkit.org/attachment.cgi?id=237616&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237616&action=review


> Source/WebKit2/ChangeLog:8
> +	   Reset the committed URL when a new load starts.

I don't see how this can be right. When a load hasn't been committed yet, the
current page is unchanged - this is the very reason for having an uncommitted
state. If the user starts a load and immediately hits Esc to cancel, the page
should remain in the same state that it was before load.