[webkit-reviews] review granted: [Bug 136534] Remove ResourceResponse::m_suggestedFilename : [Attachment 237630] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 136534: Remove ResourceResponse::m_suggestedFilename
https://bugs.webkit.org/show_bug.cgi?id=136534

Attachment 237630: patch
https://bugs.webkit.org/attachment.cgi?id=237630&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review


r=me.

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:62
> +    for (const auto& header : m_httpHeaderFields)

I think that "auto&" is all the rage these days, not "const auto&".

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:812
> +    auto* headers = [NSMutableDictionary dictionaryWithObjectsAndKeys:

I think that we can and should use @{} here, there seems to be no reason for
the dictionary to be mutable.