[webkit-reviews] review granted: [Bug 136461] Move computeInlinePreferredLogicalWidths() from RenderBlock to RenderBlockFlow : [Attachment 237511] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 4 01:30:03 PDT 2014


Darin Adler <darin at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 136461: Move computeInlinePreferredLogicalWidths() from RenderBlock to
RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=136461

Attachment 237511: Patch
https://bugs.webkit.org/attachment.cgi?id=237511&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237511&action=review


> Source/WebCore/rendering/RenderBlockFlow.cpp:3794
> +    const RenderObject* parent;

Should be RenderBlockFlow&, not RenderObject*.

> Source/WebCore/rendering/RenderBlockFlow.cpp:3799
> +    InlineMinMaxIterator(const RenderObject* p)

Should be RenderBlockFlow&, not RenderObject*.


More information about the webkit-reviews mailing list