[webkit-reviews] review granted: [Bug 11049] XMLHttpRequest always defaults Content-Type to application/xml, while it should depend on data type : [Attachment 237509] Adding new baselines for mac and efl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 23:28:12 PDT 2014


Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 11049: XMLHttpRequest always defaults Content-Type to application/xml,
while it should depend on data type
https://bugs.webkit.org/show_bug.cgi?id=11049

Attachment 237509: Adding new baselines for mac and efl
https://bugs.webkit.org/attachment.cgi?id=237509&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237509&action=review


> Source/WebCore/xml/XMLHttpRequest.cpp:596
> +		   setRequestHeaderInternal("Content-Type",
document->isHTMLDocument() ?
"text/html;charset=UTF-8":"application/xml;charset=UTF-8");

Wrong formatting here. There should be spaces around the colon.

All the string literals that are being passed as String should have
ASCIILiteral around them, to eliminate unnecessary memory allocation.


More information about the webkit-reviews mailing list