[webkit-reviews] review denied: [Bug 135255] Merge CheckingContexts from SelectorCompiler and SelectorChecker : [Attachment 237416] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 20:49:24 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has denied Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 135255: Merge CheckingContexts from SelectorCompiler and SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=135255

Attachment 237416: Patch
https://bugs.webkit.org/attachment.cgi?id=237416&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237416&action=review


Sorry for the delay, I was finishing on some style invalidation bug.

The patch is a good improvement of the code base.

You can remove SelectorQueryFastPath instead of cleaning it up.
SelectorQueryFastPath was invented by Antti to solve the performance problems
before we had the CSS JIT. Nowadays it is no longer useful, the JIT is a lot
faster.

> Source/WebCore/ChangeLog:4
> +	   Merge CheckingContexts from SelectorCompiler and SelectorChecker
> +	   https://bugs.webkit.org/show_bug.cgi?id=135255

You have 2 changeslog entries.

> Source/WebCore/CMakeLists.txt:1306
> -    css/SelectorCheckerFastPath.cpp
>      css/SelectorFilter.cpp
> +    css/SelectorQueryFastPath.cpp

You don't need to bother with SelectorCheckerFastPath. We should remove it, I
just haven't had time to clean up SelectorQuery.


More information about the webkit-reviews mailing list