[webkit-reviews] review granted: [Bug 136514] Initial letters should clear one another : [Attachment 237599] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 136514: Initial letters should clear one another
https://bugs.webkit.org/show_bug.cgi?id=136514

Attachment 237599: Patch
https://bugs.webkit.org/attachment.cgi?id=237599&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237599&action=review


> Source/WebCore/rendering/RenderBlockFlow.cpp:2304
> +    bool isInitialLetter = childBox.style().styleType() == FIRST_LETTER &&
childBox.style().initialLetterDrop() > 0;

Seems like this could be an inline function on RenderStyle.

> Source/WebCore/rendering/RenderBlockFlow.cpp:2576
> +    const FloatingObjectSet& floatingObjectSet = m_floatingObjects->set();

auto?

> Source/WebCore/rendering/RenderBlockFlow.cpp:2580
> +	   if (floatingObject->isPlaced() &&
floatingObject->renderer().style().styleType() == FIRST_LETTER &&
floatingObject->renderer().style().initialLetterDrop() > 0)

Then you could say floatingObject->renderer().style().hasInitialLetter() here.