[webkit-reviews] review denied: [Bug 136485] Segmentation fault in WTF::RefPtr<JSC::JITCode>::get() : [Attachment 237560] WIP patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied Akos Kiss
<akiss at inf.u-szeged.hu>'s request for review:
Bug 136485: Segmentation fault in WTF::RefPtr<JSC::JITCode>::get()
https://bugs.webkit.org/show_bug.cgi?id=136485

Attachment 237560: WIP patch
https://bugs.webkit.org/attachment.cgi?id=237560&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
r-

This seems too complicated with stack pointer adjustments that seem a little
arbitrary.

I'm working on a patch that should resolve this and the issues in
https://bugs.webkit.org/show_bug.cgi?id=136436.  Basically restore the
stackPointer to the normal value before compileCallEval().  We know that there
is enough space for outgoing register arguments, that is accounted for in
stackPointerOffsetFor(m_codeBlock) for architectures that have stack based
arguments.  What I'm suggesting should be much simpler.