[webkit-reviews] review granted: [Bug 136486] [Win] Revise test environment for Windows build : [Attachment 237562] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 136486: [Win] Revise test environment for Windows build
https://bugs.webkit.org/show_bug.cgi?id=136486

Attachment 237562: Patch
https://bugs.webkit.org/attachment.cgi?id=237562&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237562&action=review


r=me

> Tools/Scripts/webkitdirs.pm:765
> +    die "Safari Path is only relevant on Mac platform\n" unless
isAppleMacWebKit();

Nit:  Lowercase "Path"?  Maybe say instead:

    die "Safari path is only relevant on Apple Mac platform\n" unless
isAppleMacWebKit();

> Tools/Scripts/webkitdirs.pm:784
> +    die "Safari Path is only relevant on Mac platform\n" unless
isAppleMacWebKit();

Same:

    die "Safari path is only relevant on Apple Mac platform\n" unless
isAppleMacWebKit();