[webkit-reviews] review granted: [Bug 136472] Fix style invalidation of elements with multiple siblings dependencies : [Attachment 237542] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 136472: Fix style invalidation of elements with multiple siblings
dependencies
https://bugs.webkit.org/show_bug.cgi?id=136472

Attachment 237542: Patch
https://bugs.webkit.org/attachment.cgi?id=237542&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237542&action=review


r=me

> Source/WebCore/html/HTMLElement.h:91
> -    bool isHTMLUnknownElement() const { return
getFlag(IsHTMLUnknownElementFlag); }
> +    virtual bool isHTMLUnknownElement() const { return false; }

RIP my micro-optimization :|

> Source/WebCore/html/HTMLUnknownElement.h:44
> +    virtual bool isHTMLUnknownElement() const { return true; }

Missing override.