[webkit-reviews] review granted: [Bug 136468] MallocBench should have a stress test for correctness : [Attachment 237524] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 10:27:38 PDT 2014


Andreas Kling <akling at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 136468: MallocBench should have a stress test for correctness
https://bugs.webkit.org/show_bug.cgi?id=136468

Attachment 237524: Patch
https://bugs.webkit.org/attachment.cgi?id=237524&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237524&action=review


r=me

> PerformanceTests/ChangeLog:21
> +	   (benchmark_stress): Usually, we random(0). Surprisingly, though,
only
> +	   random(1) reproduces the bug I was looking for.

This feels a bit sketchy, but it's better than not having a test at all.


More information about the webkit-reviews mailing list