[webkit-reviews] review granted: [Bug 136473] Avoid warning if a process does not have access to com.apple.webinspector : [Attachment 237539] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136473: Avoid warning if a process does not have access to
com.apple.webinspector
https://bugs.webkit.org/show_bug.cgi?id=136473

Attachment 237539: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=237539&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237539&action=review


> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:59
> +#if __has_include(<sandbox/private.h>)
> +#import <sandbox/private.h>
> +#else
> +enum sandbox_filter_type {
> +    SANDBOX_FILTER_GLOBAL_NAME,
> +};
> +extern "C" {
> +int sandbox_check(pid_t, const char *operation, enum sandbox_filter_type,
...);
> +}
> +#endif

Sandbox SPIs seem like a prime target for the new technique Maciej is
suggesting, as we use them in many places. Instead of declaring the SPIs in
each .mm file, they would go into SandboxSPI.h.

In any case, sandbox_check declaration should not be inside the #else.