[webkit-reviews] review granted: [Bug 136458] Optimize own property GetByVals with rope string subscripts. : [Attachment 237505] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 136458: Optimize own property GetByVals with rope string subscripts.
https://bugs.webkit.org/show_bug.cgi?id=136458

Attachment 237505: Patch
https://bugs.webkit.org/attachment.cgi?id=237505&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237505&action=review


r=me

> Source/JavaScriptCore/dfg/DFGOperations.cpp:300
> +		   if (AtomicStringImpl* existingAtomicString =
asString(property)->toExistingAtomicString(exec)) {

This is a clever observation. I wonder if we should build it into JSObject, by
providing a (fast?)getOwnProperty() that takes a JSString* argument. That would
simplify some of the call sites, and it would encourage folks writing code that
used JSString* to do the right thing by default.