[webkit-reviews] review granted: [Bug 136044] [CSS Font Loading] Enable Page Caching : [Attachment 237326] Skipping test

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Bear Travis <betravis at adobe.com>'s
request for review:
Bug 136044: [CSS Font Loading] Enable Page Caching
https://bugs.webkit.org/show_bug.cgi?id=136044

Attachment 237326: Skipping test
https://bugs.webkit.org/attachment.cgi?id=237326&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237326&action=review


r=me as the logic appears sound.

> Source/WebCore/css/FontLoader.cpp:72
> +    int familyCount() const { return m_numFamilies; }

I'd call it m_familyCount for consistency.

> Source/WebCore/css/FontLoader.h:104
> +    unsigned m_rulesLoading;
> +    unsigned m_stringsLoading;

Can we come up with some better names for these?
m_stringsLoading is especially unobvious.