[webkit-reviews] review granted: [Bug 136194] [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES : [Attachment 237193] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 1 01:47:45 PDT 2014


Csaba Osztrogonác <ossy at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at webkit.org>'s request for review:
Bug 136194: [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES
https://bugs.webkit.org/show_bug.cgi?id=136194

Attachment 237193: Patch
https://bugs.webkit.org/attachment.cgi?id=237193&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237193&action=review


rs=me

> Source/JavaScriptCore/ChangeLog:8
> +	   Set the LINK_INTERFACE_LIBRARIES target property on the tol level
CMakeLists.txt.

typo: tol -> top

> Source/WebCore/ChangeLog:8
> +	   Set the LINK_INTERFACE_LIBRARIES target property on the top level
CMakeLists.txt.

ditto

> Source/WebKit2/ChangeLog:8
> +	   Set the LINK_INTERFACE_LIBRARIES target property on the top level
CMakeLists.txt.

ditto

> ChangeLog:8
> +	   Set the LINK_INTERFACE_LIBRARIES target property on the tol level
CMakeLists.txt.

ditto


More information about the webkit-reviews mailing list