[webkit-reviews] review requested: [Bug 138039] [Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks() : [Attachment 240397] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 138039: [Mac] Use NSString API in
QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
https://bugs.webkit.org/show_bug.cgi?id=138039

Attachment 240397: Patch

https://bugs.webkit.org/attachment.cgi?id=240397&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Created attachment 240397
  --> https://bugs.webkit.org/attachment.cgi?id=240397&action=review
Patch

Gosh, [NSString caseInsensitiveCompare] returns True if the NSString is nil :)

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 240397
  --> https://bugs.webkit.org/attachment.cgi?id=240397
Patch

Did you land this already? I would set review+ but it does’t have review?.

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #5)
> Comment on attachment 240397 [details]
> Patch
> 
> Did you land this already? I would set review+ but it does’t have review?.

I did not land it. Bugzilla just won't let me set the review flag (gives me an
error)...